From 6e4fe7131a72a9b7b6891783a645947aaf7a5d00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Wysoki=C5=84ski?= Date: Tue, 20 Feb 2024 07:39:00 +0100 Subject: [PATCH] refactor: variable shadowing for t.Parallel is no longer needed --- internal/adapter/repository_ennoblement_test.go | 2 -- internal/adapter/repository_player_snapshot_test.go | 2 -- internal/adapter/repository_player_test.go | 2 -- internal/adapter/repository_server_test.go | 2 -- internal/adapter/repository_tribe_change_test.go | 2 -- internal/adapter/repository_tribe_snapshot_test.go | 2 -- internal/adapter/repository_tribe_test.go | 4 ---- internal/adapter/repository_version_test.go | 2 -- internal/adapter/repository_village_test.go | 2 -- internal/chislog/chislog_test.go | 2 -- internal/domain/base_ennoblement_test.go | 2 -- internal/domain/base_player_test.go | 2 -- internal/domain/base_server_test.go | 2 -- internal/domain/base_tribe_test.go | 2 -- internal/domain/base_village_test.go | 2 -- internal/domain/ennoblement_test.go | 6 ------ internal/domain/opponents_defeated_test.go | 2 -- internal/domain/player_snapshot_test.go | 6 ------ internal/domain/player_test.go | 10 ---------- internal/domain/server_test.go | 12 ------------ internal/domain/tribe_change_test.go | 8 -------- internal/domain/tribe_snapshot_test.go | 6 ------ internal/domain/tribe_test.go | 10 ---------- internal/domain/version_test.go | 8 -------- internal/domain/village_test.go | 10 ---------- internal/health/health_test.go | 4 ---- internal/health/healthhttp/handler_test.go | 4 ---- internal/port/handler_http_api_openapi_test.go | 2 -- internal/tw/client_test.go | 10 ---------- internal/tw/server_config_test.go | 2 -- 30 files changed, 132 deletions(-) diff --git a/internal/adapter/repository_ennoblement_test.go b/internal/adapter/repository_ennoblement_test.go index a1e8fd7..47ca103 100644 --- a/internal/adapter/repository_ennoblement_test.go +++ b/internal/adapter/repository_ennoblement_test.go @@ -292,8 +292,6 @@ func testEnnoblementRepository(t *testing.T, newRepos func(t *testing.T) reposit } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_player_snapshot_test.go b/internal/adapter/repository_player_snapshot_test.go index 6f3148d..ea7dc12 100644 --- a/internal/adapter/repository_player_snapshot_test.go +++ b/internal/adapter/repository_player_snapshot_test.go @@ -317,8 +317,6 @@ func testPlayerSnapshotRepository(t *testing.T, newRepos func(t *testing.T) repo } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_player_test.go b/internal/adapter/repository_player_test.go index cd5ab52..580e870 100644 --- a/internal/adapter/repository_player_test.go +++ b/internal/adapter/repository_player_test.go @@ -304,8 +304,6 @@ func testPlayerRepository(t *testing.T, newRepos func(t *testing.T) repositories } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_server_test.go b/internal/adapter/repository_server_test.go index bc6b3df..37d8c76 100644 --- a/internal/adapter/repository_server_test.go +++ b/internal/adapter/repository_server_test.go @@ -498,8 +498,6 @@ func testServerRepository(t *testing.T, newRepos func(t *testing.T) repositories } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_tribe_change_test.go b/internal/adapter/repository_tribe_change_test.go index 40d5e7c..c27d5e7 100644 --- a/internal/adapter/repository_tribe_change_test.go +++ b/internal/adapter/repository_tribe_change_test.go @@ -309,8 +309,6 @@ func testTribeChangeRepository(t *testing.T, newRepos func(t *testing.T) reposit } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_tribe_snapshot_test.go b/internal/adapter/repository_tribe_snapshot_test.go index 41b5a67..20220d0 100644 --- a/internal/adapter/repository_tribe_snapshot_test.go +++ b/internal/adapter/repository_tribe_snapshot_test.go @@ -315,8 +315,6 @@ func testTribeSnapshotRepository(t *testing.T, newRepos func(t *testing.T) repos } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_tribe_test.go b/internal/adapter/repository_tribe_test.go index 2e2a2c9..e846385 100644 --- a/internal/adapter/repository_tribe_test.go +++ b/internal/adapter/repository_tribe_test.go @@ -136,8 +136,6 @@ func testTribeRepository(t *testing.T, newRepos func(t *testing.T) repositories) } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -746,8 +744,6 @@ func testTribeRepository(t *testing.T, newRepos func(t *testing.T) repositories) } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_version_test.go b/internal/adapter/repository_version_test.go index 7f91e93..2f2b745 100644 --- a/internal/adapter/repository_version_test.go +++ b/internal/adapter/repository_version_test.go @@ -185,8 +185,6 @@ func testVersionRepository(t *testing.T, newRepos func(t *testing.T) repositorie } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/adapter/repository_village_test.go b/internal/adapter/repository_village_test.go index 37e6de3..046dec7 100644 --- a/internal/adapter/repository_village_test.go +++ b/internal/adapter/repository_village_test.go @@ -242,8 +242,6 @@ func testVillageRepository(t *testing.T, newRepos func(t *testing.T) repositorie } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/chislog/chislog_test.go b/internal/chislog/chislog_test.go index 3056ac3..2ef3b68 100644 --- a/internal/chislog/chislog_test.go +++ b/internal/chislog/chislog_test.go @@ -120,8 +120,6 @@ func TestLogger(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/base_ennoblement_test.go b/internal/domain/base_ennoblement_test.go index dbe8d28..cfd7894 100644 --- a/internal/domain/base_ennoblement_test.go +++ b/internal/domain/base_ennoblement_test.go @@ -165,8 +165,6 @@ func TestNewBaseEnnoblement(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/base_player_test.go b/internal/domain/base_player_test.go index 1a68459..c3e71b4 100644 --- a/internal/domain/base_player_test.go +++ b/internal/domain/base_player_test.go @@ -215,8 +215,6 @@ func TestNewBasePlayer(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/base_server_test.go b/internal/domain/base_server_test.go index a53147c..dd6758d 100644 --- a/internal/domain/base_server_test.go +++ b/internal/domain/base_server_test.go @@ -69,8 +69,6 @@ func TestNewBaseServer(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/base_tribe_test.go b/internal/domain/base_tribe_test.go index ba4e801..51bc3a3 100644 --- a/internal/domain/base_tribe_test.go +++ b/internal/domain/base_tribe_test.go @@ -321,8 +321,6 @@ func TestNewBaseTribe(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/base_village_test.go b/internal/domain/base_village_test.go index 1afc689..7569f31 100644 --- a/internal/domain/base_village_test.go +++ b/internal/domain/base_village_test.go @@ -293,8 +293,6 @@ func TestNewBaseVillage(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/ennoblement_test.go b/internal/domain/ennoblement_test.go index 0f52702..cfe8b3c 100644 --- a/internal/domain/ennoblement_test.go +++ b/internal/domain/ennoblement_test.go @@ -97,8 +97,6 @@ func TestListEnnoblementsParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -162,8 +160,6 @@ func TestListEnnoblementsParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -213,8 +209,6 @@ func TestListEnnoblementsParams_SetOffset(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/opponents_defeated_test.go b/internal/domain/opponents_defeated_test.go index a4b504e..22ff822 100644 --- a/internal/domain/opponents_defeated_test.go +++ b/internal/domain/opponents_defeated_test.go @@ -214,8 +214,6 @@ func TestNewOpponentsDefeated(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/player_snapshot_test.go b/internal/domain/player_snapshot_test.go index 8b5d6da..e491d61 100644 --- a/internal/domain/player_snapshot_test.go +++ b/internal/domain/player_snapshot_test.go @@ -103,8 +103,6 @@ func TestListPlayerSnapshotsParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -168,8 +166,6 @@ func TestListPlayerSnapshotsParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -219,8 +215,6 @@ func TestListPlayerSnapshotsParams_SetOffset(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/player_test.go b/internal/domain/player_test.go index 105eefc..88ac021 100644 --- a/internal/domain/player_test.go +++ b/internal/domain/player_test.go @@ -273,8 +273,6 @@ func TestListPlayersParams_SetIDs(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -330,8 +328,6 @@ func TestListPlayersParams_SetIDGT(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -404,8 +400,6 @@ func TestListPlayersParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -469,8 +463,6 @@ func TestListPlayersParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -520,8 +512,6 @@ func TestListPlayersParams_SetOffset(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/server_test.go b/internal/domain/server_test.go index 82ed1d3..e9e4ee8 100644 --- a/internal/domain/server_test.go +++ b/internal/domain/server_test.go @@ -103,8 +103,6 @@ func TestNewCreateServerParams(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -171,8 +169,6 @@ func TestUpdateServerParams_SetNumTribes(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -229,8 +225,6 @@ func TestNewServerCursor(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -303,8 +297,6 @@ func TestListServersParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -385,8 +377,6 @@ func TestListServersParams_SetEncodedCursor(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -452,8 +442,6 @@ func TestListServersParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/tribe_change_test.go b/internal/domain/tribe_change_test.go index 05eb115..7955a1d 100644 --- a/internal/domain/tribe_change_test.go +++ b/internal/domain/tribe_change_test.go @@ -111,8 +111,6 @@ func TestNewCreateTribeChangeParams(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -275,8 +273,6 @@ func TestListTribeChangesParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -340,8 +336,6 @@ func TestListTribeChangesParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -391,8 +385,6 @@ func TestListTribeChangesParams_SetOffset(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/tribe_snapshot_test.go b/internal/domain/tribe_snapshot_test.go index 4c38d4a..8aa6003 100644 --- a/internal/domain/tribe_snapshot_test.go +++ b/internal/domain/tribe_snapshot_test.go @@ -105,8 +105,6 @@ func TestListTribeSnapshotsParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -170,8 +168,6 @@ func TestListTribeSnapshotsParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -221,8 +217,6 @@ func TestListTribeSnapshotsParams_SetOffset(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/tribe_test.go b/internal/domain/tribe_test.go index 80643e4..afc6079 100644 --- a/internal/domain/tribe_test.go +++ b/internal/domain/tribe_test.go @@ -346,8 +346,6 @@ func TestNewTribeCursor(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -418,8 +416,6 @@ func TestListTribesParams_SetIDs(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -494,8 +490,6 @@ func TestListTribesParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -755,8 +749,6 @@ func TestListTribesParams_SetEncodedCursor(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -822,8 +814,6 @@ func TestListTribesParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/version_test.go b/internal/domain/version_test.go index 43825a4..99889ed 100644 --- a/internal/domain/version_test.go +++ b/internal/domain/version_test.go @@ -51,8 +51,6 @@ func TestNewVersionCursor(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -123,8 +121,6 @@ func TestListVersionsParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -205,8 +201,6 @@ func TestListVersionsParams_SetEncodedCursor(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -271,8 +265,6 @@ func TestListVersionsParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/domain/village_test.go b/internal/domain/village_test.go index b7686d2..1b91563 100644 --- a/internal/domain/village_test.go +++ b/internal/domain/village_test.go @@ -134,8 +134,6 @@ func TestListVillagesParams_SetIDs(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -191,8 +189,6 @@ func TestListVillagesParams_SetIDGT(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -265,8 +261,6 @@ func TestListVillagesParams_SetSort(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -330,8 +324,6 @@ func TestListVillagesParams_SetLimit(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -381,8 +373,6 @@ func TestListVillagesParams_SetOffset(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/health/health_test.go b/internal/health/health_test.go index 95dfce5..32138de 100644 --- a/internal/health/health_test.go +++ b/internal/health/health_test.go @@ -87,8 +87,6 @@ func TestHealth_CheckReady(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -176,8 +174,6 @@ func TestHealth_CheckLive(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/health/healthhttp/handler_test.go b/internal/health/healthhttp/handler_test.go index c170f24..fad1675 100644 --- a/internal/health/healthhttp/handler_test.go +++ b/internal/health/healthhttp/handler_test.go @@ -84,8 +84,6 @@ func TestReadyHandler(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -173,8 +171,6 @@ func TestLiveHandler(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/port/handler_http_api_openapi_test.go b/internal/port/handler_http_api_openapi_test.go index 4d61193..be449c0 100644 --- a/internal/port/handler_http_api_openapi_test.go +++ b/internal/port/handler_http_api_openapi_test.go @@ -88,8 +88,6 @@ func TestOpenAPI(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.target, func(t *testing.T) { t.Parallel() diff --git a/internal/tw/client_test.go b/internal/tw/client_test.go index 872d105..43aacd7 100644 --- a/internal/tw/client_test.go +++ b/internal/tw/client_test.go @@ -780,8 +780,6 @@ func TestClient_GetTribes(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -1063,8 +1061,6 @@ func TestClient_GetPlayers(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -1240,8 +1236,6 @@ func TestClient_GetVillages(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -1410,8 +1404,6 @@ func TestClient_GetEnnoblements(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -1632,8 +1624,6 @@ func TestClient_GetEnnoblements(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/internal/tw/server_config_test.go b/internal/tw/server_config_test.go index 85aebf6..98c395b 100644 --- a/internal/tw/server_config_test.go +++ b/internal/tw/server_config_test.go @@ -52,8 +52,6 @@ func TestKnightNewItems_UnmarshalXML(t *testing.T) { } for _, tt := range tests { - tt := tt - t.Run(tt.data, func(t *testing.T) { t.Parallel()