twhelp
/
core
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects Releases 6 Wiki Activity

refactor: change path of one of the api endpoints (listTribeTribeChanges -> listTribeMemberChanges)
ci/woodpecker/push/govulncheck Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details

This commit is contained in:
Dawid Wysokiński 2024-03-19 08:06:46 +01:00
parent f4d6824571
commit 267953ea61
Signed by: Kichiyaki
GPG Key ID: B5445E357FB8B892
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/openapi3.yml
View File

@ -419,15 +419,15 @@ paths:
$ref: "#/components/responses/ListTribeChangesResponse" $ref: "#/components/responses/ListTribeChangesResponse"
default: default:
$ref: "#/components/responses/ErrorResponse" $ref: "#/components/responses/ErrorResponse"
/v2/versions/{versionCode}/servers/{serverKey}/tribes/{tribeId}/tribe-changes: /v2/versions/{versionCode}/servers/{serverKey}/tribes/{tribeId}/member-changes:
get: get:
operationId: listTribeTribeChanges operationId: listTribeMemberChanges
tags: tags:
- versions - versions
- servers - servers
- tribes - tribes
- tribe-changes - tribe-changes
description: List tribe membership changes description: List the given tribe's member changes (who joined, who left, etc.)
parameters: parameters:
- $ref: "#/components/parameters/VersionCodePathParam" - $ref: "#/components/parameters/VersionCodePathParam"
- $ref: "#/components/parameters/ServerKeyPathParam" - $ref: "#/components/parameters/ServerKeyPathParam"

4
internal/port/handler_http_api_tribe_change.go
View File

@ -90,13 +90,13 @@ func (h *apiHTTPHandler) ListPlayerTribeChanges(
} }
//nolint:gocyclo //nolint:gocyclo
func (h *apiHTTPHandler) ListTribeTribeChanges( func (h *apiHTTPHandler) ListTribeMemberChanges(
w http.ResponseWriter, w http.ResponseWriter,
r *http.Request, r *http.Request,
_ apimodel.VersionCodePathParam, _ apimodel.VersionCodePathParam,
serverKey apimodel.ServerKeyPathParam, serverKey apimodel.ServerKeyPathParam,
tribeID apimodel.TribeIdPathParam, tribeID apimodel.TribeIdPathParam,
params apimodel.ListTribeTribeChangesParams, params apimodel.ListTribeMemberChangesParams,
) { ) {
domainParams := domain.NewListTribeChangesParams() domainParams := domain.NewListTribeChangesParams()

12
internal/port/handler_http_api_tribe_change_test.go
View File

@ -730,9 +730,9 @@ func TestListPlayerTribeChanges(t *testing.T) {
} }
} }
const endpointListTribeTribeChanges = "/v2/versions/%s/servers/%s/tribes/%d/tribe-changes" const endpointListTribeMemberChanges = "/v2/versions/%s/servers/%s/tribes/%d/member-changes"
func TestListTribeTribeChanges(t *testing.T) { func TestListTribeMemberChanges(t *testing.T) {
t.Parallel() t.Parallel()
handler := newAPIHTTPHandler(t) handler := newAPIHTTPHandler(t)
@ -1331,7 +1331,7 @@ func TestListTribeTribeChanges(t *testing.T) {
name: "ERR: version not found", name: "ERR: version not found",
reqModifier: func(t *testing.T, req *http.Request) { reqModifier: func(t *testing.T, req *http.Request) {
t.Helper() t.Helper()
req.URL.Path = fmt.Sprintf(endpointListTribeTribeChanges, randInvalidVersionCode(t, handler), server.Key, tribe.Id) req.URL.Path = fmt.Sprintf(endpointListTribeMemberChanges, randInvalidVersionCode(t, handler), server.Key, tribe.Id)
}, },
assertResp: func(t *testing.T, req *http.Request, resp *http.Response) { assertResp: func(t *testing.T, req *http.Request, resp *http.Response) {
t.Helper() t.Helper()
@ -1363,7 +1363,7 @@ func TestListTribeTribeChanges(t *testing.T) {
reqModifier: func(t *testing.T, req *http.Request) { reqModifier: func(t *testing.T, req *http.Request) {
t.Helper() t.Helper()
req.URL.Path = fmt.Sprintf( req.URL.Path = fmt.Sprintf(
endpointListTribeTribeChanges, endpointListTribeMemberChanges,
server.Version.Code, server.Version.Code,
domaintest.RandServerKey(), domaintest.RandServerKey(),
tribe.Id, tribe.Id,
@ -1399,7 +1399,7 @@ func TestListTribeTribeChanges(t *testing.T) {
reqModifier: func(t *testing.T, req *http.Request) { reqModifier: func(t *testing.T, req *http.Request) {
t.Helper() t.Helper()
req.URL.Path = fmt.Sprintf( req.URL.Path = fmt.Sprintf(
endpointListTribeTribeChanges, endpointListTribeMemberChanges,
server.Version.Code, server.Version.Code,
server.Key, server.Key,
domaintest.RandID(), domaintest.RandID(),
@ -1442,7 +1442,7 @@ func TestListTribeTribeChanges(t *testing.T) {
req := httptest.NewRequest( req := httptest.NewRequest(
http.MethodGet, http.MethodGet,
fmt.Sprintf(endpointListTribeTribeChanges, server.Version.Code, server.Key, tribe.Id), fmt.Sprintf(endpointListTribeMemberChanges, server.Version.Code, server.Key, tribe.Id),
nil, nil,
) )
if tt.reqModifier != nil { if tt.reqModifier != nil {