twhelp
/
dcbot-old
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove unnecessary allocation in isValidLanguageTag, rename getEmojiForGroupsCommand -> boolToEmoji

This commit is contained in:
Dawid Wysokiński 2021-07-18 07:28:48 +02:00
parent 704928d9b4
commit 937e50b23e
3 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
discord/embed.go
View File

@ -255,6 +255,7 @@ func (b *MessageEmbedFieldBuilder) IsEmpty() bool {
func (b *MessageEmbedFieldBuilder) Append(m string) { func (b *MessageEmbedFieldBuilder) Append(m string) {
b.mutex.Lock() b.mutex.Lock()
defer b.mutex.Unlock() defer b.mutex.Unlock()
for len(b.chunks) < b.index+1 { for len(b.chunks) < b.index+1 {
b.chunks = append(b.chunks, "") b.chunks = append(b.chunks, "")
} }

10
discord/helpers.go
View File

@ -7,7 +7,7 @@ import (
"github.com/tribalwarshelp/dcbot/message" "github.com/tribalwarshelp/dcbot/message"
) )
func getEmojiForGroupsCommand(val bool) string { func boolToEmoji(val bool) string {
if val { if val {
return ":white_check_mark:" return ":white_check_mark:"
} }
@ -15,7 +15,7 @@ func getEmojiForGroupsCommand(val bool) string {
} }
func getAvailableLanguages() string { func getAvailableLanguages() string {
langTags := []string{} var langTags []string
for _, langTag := range message.LanguageTags() { for _, langTag := range message.LanguageTags() {
langTags = append(langTags, langTag.String()) langTags = append(langTags, langTag.String())
} }
@ -23,14 +23,12 @@ func getAvailableLanguages() string {
} }
func isValidLanguageTag(lang string) bool { func isValidLanguageTag(lang string) bool {
valid := false
for _, langTag := range message.LanguageTags() { for _, langTag := range message.LanguageTags() {
if langTag.String() == lang { if langTag.String() == lang {
valid = true return true
break
} }
} }
return valid return false
} }
func BuildLink(text string, url string) string { func BuildLink(text string, url string) string {

8
discord/observations.go
View File

@ -147,10 +147,10 @@ func (s *Session) handleGroupsCommand(ctx *commandCtx, m *discordgo.MessageCreat
msg += fmt.Sprintf("**%d** | %d | %s | %s | %s | %s\n", i+1, msg += fmt.Sprintf("**%d** | %d | %s | %s | %s | %s\n", i+1,
groups.ID, groups.ID,
getEmojiForGroupsCommand(groups.ConqueredVillagesChannelID != ""), boolToEmoji(groups.ConqueredVillagesChannelID != ""),
getEmojiForGroupsCommand(groups.LostVillagesChannelID != ""), boolToEmoji(groups.LostVillagesChannelID != ""),
getEmojiForGroupsCommand(groups.ShowEnnobledBarbarians), boolToEmoji(groups.ShowEnnobledBarbarians),
getEmojiForGroupsCommand(groups.ShowInternals), boolToEmoji(groups.ShowInternals),
) )
} }